feat: add Codex skill install guidance#815
Conversation
WalkthroughThis PR adds Codex agent support by introducing a reusable dry-refactoring skill installation command, testing CLI tip output, and documenting installation for both jscpd and dry-refactoring skills targeting Codex's user skills directory. ChangesCodex Agent Skill Support
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/jscpd/README.md`:
- Around line 632-640: Update the Codex install example so it's self-contained
by including the --global variant in the command snippet itself and matching the
surrounding explanatory sentence; specifically modify the command shown (`npx
skills add kucherenko/jscpd --skill jscpd --skill dry-refactoring --agent
codex`) to also show the global form (`npx skills add ... --agent codex
--global`) and adjust the adjacent text so both the inline example and the
explanatory line consistently state that adding --global installs to Codex's
user skills directory (~/.codex/skills/) while omitting it installs to the
project's .agents/skills/ directory.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 11a33773-dcef-4b20-b6bf-d780fdfcd439
📒 Files selected for processing (4)
apps/jscpd/README.mdapps/jscpd/__tests__/options.test.tsapps/jscpd/src/index.tsdocs/ai-ready.md
| To install both skills for Codex explicitly: | ||
|
|
||
| ```bash | ||
| npx skills add kucherenko/jscpd --skill jscpd --skill dry-refactoring --agent codex | ||
| ``` | ||
|
|
||
| Add `--global` to install into Codex's user skills directory | ||
| (`~/.codex/skills/`) instead of the current project's `.agents/skills/` | ||
| directory. |
There was a problem hiding this comment.
Make the Codex install example self-contained. The new Codex section says the command is the explicit install, but --global is only mentioned afterward. As written, copy-paste users can miss the Codex user-directory install the surrounding text is describing.
Suggested edit
-npx skills add kucherenko/jscpd --skill jscpd --skill dry-refactoring --agent codex
+npx skills add kucherenko/jscpd --skill jscpd --skill dry-refactoring --agent codex --globalApply the same wording in both docs.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| To install both skills for Codex explicitly: | |
| ```bash | |
| npx skills add kucherenko/jscpd --skill jscpd --skill dry-refactoring --agent codex | |
| ``` | |
| Add `--global` to install into Codex's user skills directory | |
| (`~/.codex/skills/`) instead of the current project's `.agents/skills/` | |
| directory. | |
| To install both skills for Codex explicitly: | |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/jscpd/README.md` around lines 632 - 640, Update the Codex install
example so it's self-contained by including the --global variant in the command
snippet itself and matching the surrounding explanatory sentence; specifically
modify the command shown (`npx skills add kucherenko/jscpd --skill jscpd --skill
dry-refactoring --agent codex`) to also show the global form (`npx skills add
... --agent codex --global`) and adjust the adjacent text so both the inline
example and the explanatory line consistently state that adding --global
installs to Codex's user skills directory (~/.codex/skills/) while omitting it
installs to the project's .agents/skills/ directory.
Feature / docs update.
Closes #800.
The AI skill documentation lists generic
npx skills addcommands, and the CLI tip points tonpx skills add kucherenko/jscpdwithout naming the refactoring skill. Users looking for Codex support have to infer that the existing agent skills can be installed for Codex via theskillsCLI.npx skills add kucherenko/jscpd --skill jscpd --skill dry-refactoring --agent codex--globalinstalls the skills for Codex.dry-refactoringskill install command.--noTipssuppression.Validation run locally:
npx skills add . --listpnpm --filter jscpd test -- __tests__/options.test.ts -t tipspnpm --filter jscpd typecheckpnpm buildgit diff --check HEADThis change is
Summary by CodeRabbit
Documentation
--globalflag examples for user-level installation.New Features