Skip to content

[manila-csi-plugin, cinder-csi-plugin]: Allow cluster-id to be populated from configmap / secret - #3152

Merged
kubernetes-prow[bot] merged 3 commits into
kubernetes:masterfrom
1602077:feat/cluster-id-from-secret
Jul 29, 2026
Merged

[manila-csi-plugin, cinder-csi-plugin]: Allow cluster-id to be populated from configmap / secret#3152
kubernetes-prow[bot] merged 3 commits into
kubernetes:masterfrom
1602077:feat/cluster-id-from-secret

Conversation

@1602077

@1602077 1602077 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Follow up from #3069 which got closed when I rebased and I can not reopen now.

What this PR does / why we need it:

Adds supports for loading cluster_id from a secret / configmap in cluster. If clusterID is not set then CLUSTER_NAME can be overridden using extraEnv to pull configuration from an external object.

e.g.

# values.yaml
openstack-cinder-csi:
  clusterID: ""
  secret:
    filename: "cloud-config"
  csi:
    plugin:
      extraEnv:
        - name: CLUSTER_NAME
          valueFrom:
            configMapKeyRef:
              name: cluster-info
              key: cluster_uuid

This allows us to maintain a single configuration for manila / cinder for all of our cluster's, whilst ensuring that they correctly have the cluster-id metadata attached to the created shares / volumes for each cluster.

Which issue this PR fixes(if applicable):
fixes #3070

Special notes for reviewers:
None

Release note:

* [cinder-csi-plugin] Allow cluster-id to be populated from configmap / secret.
* [manila-csi-plugin] Allow cluster-id to be populated from configmap / secret.

1602077 added 3 commits July 26, 2026 20:25
Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 26, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from gouthampacha and zetaab July 26, 2026 19:27
@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 26, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @1602077. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2026
@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2026
@kayrus

kayrus commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 78fca23 into kubernetes:master Jul 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin, manila-csi-plugin]: Add support for loading cluster-id from secret / configmap

2 participants