[manila-csi-plugin, cinder-csi-plugin]: Allow cluster-id to be populated from configmap / secret - #3152
Conversation
Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
|
Hi @1602077. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kayrus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow up from #3069 which got closed when I rebased and I can not reopen now.
What this PR does / why we need it:
Adds supports for loading cluster_id from a secret / configmap in cluster. If clusterID is not set then CLUSTER_NAME can be overridden using extraEnv to pull configuration from an external object.
e.g.
This allows us to maintain a single configuration for manila / cinder for all of our cluster's, whilst ensuring that they correctly have the cluster-id metadata attached to the created shares / volumes for each cluster.
Which issue this PR fixes(if applicable):
fixes #3070
Special notes for reviewers:
None
Release note: