Skip to content

feat: add support for load balancer, listener, and pool tags annotations#3149

Open
alexanderstephan wants to merge 12 commits into
kubernetes:masterfrom
sap-contributions:pr-3058-lb-tags
Open

feat: add support for load balancer, listener, and pool tags annotations#3149
alexanderstephan wants to merge 12 commits into
kubernetes:masterfrom
sap-contributions:pr-3058-lb-tags

Conversation

@alexanderstephan

@alexanderstephan alexanderstephan commented Jul 24, 2026

Copy link
Copy Markdown

Superceds #3058.

What this PR does / why we need it:
This PR adds support for the add tags to load balancer, listener, and pool via the service annotations in cloud-provider-openstack (OCCM).

Which issue this PR fixes(if applicable):
fixes #3032 #2327

Special notes for reviewers:
You can add annotations to the service like:

loadbalancer.openstack.org/listener-tags: "tags-test"
loadbalancer.openstack.org/load-balancer-tags: "tags-test"
loadbalancer.openstack.org/pool-tags: "tags-test"

Then check if the tags have been added to the service's load blancer(the service's type should be load balancer)

Release note:

[openstack-cloud-controller-manager] Support adding tags to load balancers, listeners, and pools via Service annotations.

A10ss and others added 4 commits July 23, 2026 16:08
- Simplify mergeTags: drop unreachable nil check and redundant else
- Collapse repeated SplitTrim guard blocks at all tag call sites
- Correct annotation comments to comma-separated (not JSON) format
- Add TestMergeTags and listener-tag cases to TestBuildListenerCreateOpt
- Document load-balancer-tags, listener-tags and pool-tags annotations
@kubernetes-prow kubernetes-prow Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 24, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from anguslees and kayrus July 24, 2026 10:30
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @alexanderstephan!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @alexanderstephan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2026
@kayrus

kayrus commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2026

@kayrus kayrus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. See my comments.

Comment thread pkg/openstack/loadbalancer.go Outdated
Comment thread pkg/openstack/loadbalancer.go Outdated
Comment thread pkg/openstack/loadbalancer.go Outdated
Comment thread pkg/openstack/loadbalancer.go Outdated
@alexanderstephan
alexanderstephan requested a review from kayrus July 24, 2026 12:06
Comment thread pkg/openstack/loadbalancer.go
Comment thread pkg/openstack/loadbalancer.go

@kayrus kayrus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks much better now. I left one nit comment. @yahor-kurachkin could you take a look at this PR when you have a chance?

Comment thread pkg/openstack/loadbalancer.go

@yahor-kurachkin yahor-kurachkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Since I also working on loadbalancer.go at the moment, there will likely merge conflicts. I don't mind to resolving them on my side

@kubernetes-prow

Copy link
Copy Markdown
Contributor

@alexanderstephan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-openstack-check a673385 link true /test pull-cloud-provider-openstack-check

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hope OCCM could support add tags to LB, listeners, pools

4 participants