feat: add support for load balancer, listener, and pool tags annotations#3149
feat: add support for load balancer, listener, and pool tags annotations#3149alexanderstephan wants to merge 12 commits into
Conversation
- Simplify mergeTags: drop unreachable nil check and redundant else - Collapse repeated SplitTrim guard blocks at all tag call sites - Correct annotation comments to comma-separated (not JSON) format - Add TestMergeTags and listener-tag cases to TestBuildListenerCreateOpt - Document load-balancer-tags, listener-tags and pool-tags annotations
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @alexanderstephan! |
|
Hi @alexanderstephan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
kayrus
left a comment
There was a problem hiding this comment.
Thanks for the PR. See my comments.
kayrus
left a comment
There was a problem hiding this comment.
The PR looks much better now. I left one nit comment. @yahor-kurachkin could you take a look at this PR when you have a chance?
yahor-kurachkin
left a comment
There was a problem hiding this comment.
The PR looks good. Since I also working on loadbalancer.go at the moment, there will likely merge conflicts. I don't mind to resolving them on my side
|
@alexanderstephan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Superceds #3058.
What this PR does / why we need it:
This PR adds support for the add tags to load balancer, listener, and pool via the service annotations in cloud-provider-openstack (OCCM).
Which issue this PR fixes(if applicable):
fixes #3032 #2327
Special notes for reviewers:
You can add annotations to the service like:
Then check if the tags have been added to the service's load blancer(the service's type should be load balancer)
Release note: