Skip to content

fix: wait for hijacked connections to close during drain#16625

Open
immanuwell wants to merge 2 commits into
knative:mainfrom
immanuwell:fix/hijack-tracker-drain
Open

fix: wait for hijacked connections to close during drain#16625
immanuwell wants to merge 2 commits into
knative:mainfrom
immanuwell:fix/hijack-tracker-drain

fix: replace websocket.HijackIfPossible with inline http.Hijacker ass…

751dd09
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 7, 2026 in 1s

80.34% (target 80.00%)

View this Pull Request on Codecov

80.34% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.34%. Comparing base (516bc43) to head (751dd09).

Files with missing lines Patch % Lines
pkg/http/handler/hijack.go 84.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16625      +/-   ##
==========================================
- Coverage   80.36%   80.34%   -0.03%     
==========================================
  Files         217      217              
  Lines       13568    13592      +24     
==========================================
+ Hits        10904    10920      +16     
- Misses       2301     2307       +6     
- Partials      363      365       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.