Assert no-login password reset returns 403 from Django in container logs - #871
Merged
Conversation
atodorov
force-pushed
the
assert-password-reset-403
branch
2 times, most recently
from
September 3, 2026 18:03
bf1090b to
8ee7f28
Compare
…=False django.views.defaults.permission_denied is the 403 error handler and requires an 'exception' argument. Using it directly in a URLconf caused Django to call it as a view with only 'request', resulting in a 500 TypeError instead of a 403. Replace it with a CBV which raises PermissionDenied and goes through Django's standard handler403 machinery.
atodorov
force-pushed
the
assert-password-reset-403
branch
from
September 3, 2026 18:29
8ee7f28 to
ea31e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the "NO LOGIN - /accounts/passwordreset/ displays 404" test phase with assertions against the web_no_login container logs: