Skip to content

[#1033] Allow loading fixture pg in csb dev login - #1040

Merged
marlonbaeten merged 1 commit into
mainfrom
csb-import-fixtures
Aug 4, 2026
Merged

[#1033] Allow loading fixture pg in csb dev login#1040
marlonbaeten merged 1 commit into
mainfrom
csb-import-fixtures

Conversation

@marlonbaeten

@marlonbaeten marlonbaeten commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Closes #1033

DOD checklist

For PR maintainer

Perform these checks before marking the PR as ready:

  • I have linked the PR to at least one issue.
  • I assigned the PR to myself.
  • I have added a description how to test this PR (see "Review Instructions").
  • I have added documentation where necessary.

For reviewer

  • I have read all code changes.
  • I have audited the code quality.
  • I have tested the changes either or both:
    • locally
    • on the test environment (preferred)
  • I have validated that the PR is functionally correct (use-cases, figma designs, etc.)

Review instructions

See the new playwright test - that should succeed.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Sigrid maintainability feedback


🔒Enable security insights in your CI pipeline to detect vulnerabilities early.
Start using Sigrid CI for Security today. Learn more.


⏸️️ You are still below your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-07-31.

👍 What went well?

You fixed or improved 2 refactoring candidates.

Risk System property Location
🟡 Unit Size
(Fixed)
src/middleware/dev_login.rs
ensure_dev_store(AppState,StreamId,bool,ElectionConfig)
🟡 Unit Interfacing
(Fixed)
src/middleware/dev_login.rs
ensure_dev_store(AppState,StreamId,bool,ElectionConfig)

👎 What could be better?

Unfortunately, 4 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Unit Size
(Introduced)
src/middleware/dev_login.rs
perform_dev_login(AppState,CookieJar,DevLoginQuery,axum
http
HeaderMap,Scope)
🟠 Unit Interfacing
(Introduced)
src/middleware/dev_login.rs
perform_dev_login(AppState,CookieJar,DevLoginQuery,axum
http
HeaderMap,Scope)
🟠 Unit Interfacing
(Introduced)
src/middleware/dev_login.rs
ensure_dev_store(AppState,StreamId,bool,Option<DisplayName>,ElectionConfig)
🟡 Unit Size
(Introduced)
src/middleware/dev_login.rs
ensure_dev_store(AppState,StreamId,bool,Option<DisplayName>,ElectionConfig)

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-07-31 Before changes New/changed code
Volume N/A N/A N/A
Duplication 5.3 5.5 5.5
Unit Size 3.1 0.5 0.5
Unit Complexity 4.5 5.5 5.5
Unit Interfacing 2.4 0.5 0.5
Module Coupling 3.1 N/A N/A
Component Independence 1.9 5.5 5.5
Component Entanglement 1.6 N/A N/A
Maintainability 3.1 2.6 2.6

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

PDF diff summary

Template Input Status
model-h1 model-h1-example-1.pdf 🔵 identical
model-h1 model-h1-example-2.pdf 🔵 identical
model-h1 model-h1-example-3.pdf 🔵 identical
model-h3-1 model-h3-1-example-1.pdf 🔵 identical
model-h3-1 model-h3-1-example-2.pdf 🔵 identical
model-h3-1 model-h3-1-example-3.pdf 🔵 identical
model-h3-2 model-h3-2-example-1.pdf 🔵 identical
model-h3-2 model-h3-2-example-2.pdf 🔵 identical
model-h3-2 model-h3-2-example-3.pdf 🔵 identical
model-h4 model-h4-example-1.pdf 🔵 identical
model-h4 model-h4-example-2.pdf 🔵 identical
model-h4 model-h4-example-3.pdf 🔵 identical
model-h9 model-h9-example-1.pdf 🔵 identical
model-h9 model-h9-example-2.pdf 🔵 identical
model-h9 model-h9-example-3.pdf 🔵 identical
model-i4 model-i4-example-1.pdf 🔵 identical
model-i4 model-i4-example-2.pdf 🔵 identical

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@marlonbaeten
marlonbaeten merged commit 6cb2888 into main Aug 4, 2026
18 checks passed
@marlonbaeten
marlonbaeten deleted the csb-import-fixtures branch August 4, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable importing a hash in playwright CSB

2 participants