node/cn: hand the downloader a live staking module - #1047
Merged
ian0371 merged 1 commit intoSep 1, 2026
Conversation
The downloader copies the interface it is given at construction, and the protocol manager's field was still empty at that point, so registering the module later left the downloader holding nil. Pass it in as a constructor argument instead. Confidence: high Scope-risk: narrow Not-tested: cn.New passing a live module (needs a full node bring-up) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hyunsooda
force-pushed
the
fix/pass-staking-module-to-downloader
branch
from
August 25, 2026 04:05
fc6e11c to
e9a1914
Compare
da1suk8
approved these changes
Aug 26, 2026
ian0371
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
downloader.Newwas handedmanager.stakingModulebefore it was set, so the downloader kept a nil copy for the life of the process. Pass the module in as a constructor argument.Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Further comments