node/cn: reject bid messages from non-CN peers - #1046
Open
hyunsooda wants to merge 1 commit into
Open
Conversation
Inbound BidMsg was dispatched on protocol version and message code alone, so any peer could make a consensus node decode a bid and walk the pool's validation path. Outbound propagation already targets CN peers only; gate the inbound side the same way, next to the existing consensus-message check. Confidence: high Scope-risk: narrow Not-tested: sustained bid flooding from a malicious CN peer Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hyunsooda
force-pushed
the
fix/reject-bid-from-non-cn
branch
from
August 25, 2026 02:09
053972a to
ae5418f
Compare
da1suk8
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Inbound
BidMsgwas dispatched on protocol version and message code alone, so any peer could reach a consensus node's bid path.BroadcastBidalready targets CN peers only; require the same inbound. Resource bounds for the same path are in #1041.Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Further comments