metrics: serve Prometheus /metrics on a private mux - #1023
Open
2dvorak wants to merge 1 commit into
Open
Conversation
Starting the exporter with a nil handler served http.DefaultServeMux, exposing net/http/pprof's /debug/pprof/* (including cmdline) on the Prometheus port even with --pprof off. Use a private mux; listen address unchanged. Add a regression test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2dvorak
force-pushed
the
harden-prometheus-metrics-mux
branch
from
August 7, 2026 15:11
956a13d to
f247a1a
Compare
2dvorak
marked this pull request as ready for review
August 7, 2026 17:31
hyunsooda
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
nilhandler servedhttp.DefaultServeMux, exposing net/http/pprof's /debug/pprof/* (including cmdline) on the Prometheus port even with--pprofoffTypes of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Further comments