console, api: drop the removed bootnode authorizedNodes references - #1006
Open
hyunsooda wants to merge 2 commits into
Open
console, api: drop the removed bootnode authorizedNodes references#1006hyunsooda wants to merge 2 commits into
hyunsooda wants to merge 2 commits into
Conversation
The backing DiscoveryAPI handlers were deleted in 4879302 so that a BN accepts discovery pings from any node type with no allowlist, but the console kept advertising getAuthorizedNodes/putAuthorizedNodes/ deleteAuthorizedNodes, which now fail as unknown RPC methods. Confidence: high Scope-risk: narrow Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The listed BootnodeAPI/BootnodeRegistryAPI files no longer exist; the namespace is served by DiscoveryAPI, which exposes five table methods. Confidence: high Scope-risk: narrow Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hyunsooda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The bootnode
authorizedNodeshandlers were removed in4879302d5, but the console still advertisesbootnode_{get,put,delete}AuthorizedNodesandapi/README.mdstill lists them under twocmd/kbnfiles that no longer exist. Drops both, and replaces the README section withDiscoveryAPI's five actual methods.Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Further comments