feat(utils): add parseCommands utility to format custom command configs#555
Open
HamedHaghani wants to merge 1 commit into
Open
feat(utils): add parseCommands utility to format custom command configs#555HamedHaghani wants to merge 1 commit into
HamedHaghani wants to merge 1 commit into
Conversation
Owner
|
Hi @HamedHaghani thanks so much for being interested in contributing to this project! It's definitely been a long time since we have had any time to try to improve and update it. I skimmed over the PR and the issue associated, and I had a few questions. The PR doesn't quite seem complete as I only see one file add which includes an exported function. I was thinking maybe there was some implementation work that didn't get pushed up. Do you have any extra information on how this is getting implemented into the current workflow of the application and/or how a user would take advantage of the feature? Happy to try to help answer any questions, but please have some patience, too, as I may not be able to respond right away. |
Author
|
Hi @jwu910 – thanks for the kind reply and for reviewing my PR!
You're right — the current PR only includes the `parseCommands` utility function, as the original issue (#553) focused on just creating the parsing logic.
I didn’t integrate it into the app yet because there wasn’t an obvious place where command parsing was already being used in the current flow, and I didn’t want to add extra changes beyond what was asked.
That said, I’d be very happy to help implement or connect it into the workflow — maybe reading from the config file or extending CLI behavior — if you can point me in the right direction!
Thanks again for your time and support 😊
Sent from Yahoo Mail
On Wednesday, May 28, 2025, 2:48 PM, Joshua Wu ***@***.***> wrote:
jwu910 left a comment (jwu910/check-it-out#555)
Hi @HamedHaghani thanks so much for being interested in contributing to this project! It's definitely been a long time since we have had any time to try to improve and update it.
I skimmed over the PR and the issue associated, and I had a few questions. The PR doesn't quite seem complete as I only see one file add which includes an exported function. I was thinking maybe there was some implementation work that didn't get pushed up.
Do you have any extra information on how this is getting implemented into the current workflow of the application and/or how a user would take advantage of the feature?
Happy to try to help answer any questions, but please have some patience, too, as I may not be able to respond right away.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a utility function
parseCommandsinsrc/utils/parseCommands.ts.It takes a
commandsobject (e.g., from a config file) and parses it into an array of command objects withname,key, anddescriptionproperties. This sets up the project to better support custom command configurations.Closes #553
Types of changes
Checklist: