CMake: Add LV2_AUTO_MANIFEST and juce_enable_lv2_manifest_step - #1704
Open
emezeske wants to merge 1 commit into
Open
CMake: Add LV2_AUTO_MANIFEST and juce_enable_lv2_manifest_step#1704emezeske wants to merge 1 commit into
emezeske wants to merge 1 commit into
Conversation
emezeske
marked this pull request as ready for review
August 10, 2026 21:31
Collaborator
|
This pull request has been mentioned on The JUCE Forum. There might be relevant details there: https://forum.juce.com/t/pr-cmake-add-lv2-auto-manifest-and-juce-enable-lv2-manifest-step/69281/1 |
Mirrors VST3_AUTO_MANIFEST and juce_enable_vst3_manifest_step for the LV2 manifest generation step. The LV2 manifest helper executes the freshly built plugin, which fails when the plugin requires further processing before it can be loaded (e.g. custom signing). Setting LV2_AUTO_MANIFEST FALSE disables the automatic post-build manifest step so it can be re-enabled with juce_enable_lv2_manifest_step after any custom post-build steps have been added. juce_enable_lv2_manifest_step is a no-op when the target was configured without the LV2 format, so cross-platform projects that only enable LV2 on some platforms can call it unconditionally.
emezeske
force-pushed
the
pr/lv2-auto-manifest
branch
from
August 10, 2026 23:45
8cd6bfd to
649d24f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building a plugin that needs custom code signing fails, because the LV2 manifest helper runs the freshly built binary as a post-build step before any user-added post-build steps have had a chance to process it. VST3 already handles this case with the VST3_AUTO_MANIFEST option and juce_enable_vst3_manifest_step, but there is no LV2 equivalent, so the LV2 manifest step always runs before any user-added post-build steps.
This adds LV2_AUTO_MANIFEST and juce_enable_lv2_manifest_step mirroring the VST3 design: setting LV2_AUTO_MANIFEST FALSE disables the automatic manifest step, and juce_enable_lv2_manifest_step re-enables it after any custom post-build steps have been added.