Skip to content

AudioDeviceManager: Fix a hang when a device reports a zero buffer size #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emezeske wants to merge 1 commit into
base: develop
Choose a base branch
from
+14 −0
Open

AudioDeviceManager: Fix a hang when a device reports a zero buffer size #1703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions modules/juce_audio_devices/audio_io/juce_AudioDeviceManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,20 @@ class CallbackMaxSizeEnforcer : public AudioIODeviceCallback
jassert ((int) storedInputChannels.size() == numInputChannels);
jassert ((int) storedOutputChannels.size() == numOutputChannels);

// A device that is mid-reconfiguration can report a buffer size of 0
// (e.g. the JACK backend does this when its client is unavailable),
// which would otherwise make the chunking loop below spin forever on
// the audio thread. Emit a silent block instead; the next call to
// audioDeviceAboutToStart() will restore the real block size.
if (maximumSize <= 0)
{
for (int i = 0; i < numOutputChannels; ++i)
if (auto* channel = outputChannelData[i])
zeromem (channel, (size_t) numSamples * sizeof (float));

return;
}

int position = 0;

while (position < numSamples)
Expand Down