Document the concrete event classes for seven core events - #704
Open
MacJoom wants to merge 2 commits into
Open
Conversation
Seven core events were still dispatched as the generic Joomla\Event\Event with positional arguments. They now have concrete event classes with named arguments, so document what listeners have to change. Under New Features: the seven new classes and their arguments, and the fact that PluginHelper::import() now injects the dispatcher into plugins which declare DispatcherAwareInterface themselves. Under Removed and Backward Incompatibility: numeric argument access, the three arguments which are no longer passed by reference, the array type check on onGetStats results, and the Result type check on onFinderIndexAfterIndex. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01163pcuMPNPEmXKNaS8WJQa
Updated PR links and provided details on new concrete event classes and plugin interface changes.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven core events were still dispatched as the generic Joomla\Event\Event with positional arguments. They now have concrete event classes with named arguments, so document what listeners have to change.
Under New Features: the seven new classes and their arguments, and the fact that PluginHelper::import() now injects the dispatcher into plugins which declare DispatcherAwareInterface themselves.
Under Removed and Backward Incompatibility: numeric argument access, the three arguments which are no longer passed by reference, the array type check on onGetStats results, and the Result type check on onFinderIndexAfterIndex.