Skip to content

Deprecate getInstance function of the installer #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laoneo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate getInstance function of the installer #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions updates/64-70/new-deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,17 @@ $plugin = new Foo(
$container->get(DatabaseInterface::class)
);
$plugin->setApplication(Factory::getApplication());
```

## Installer getInstance is deprecated
- PR: https://github.com/joomla/joomla-cms/pull/47980
- File: /libraries/src/Installer/Installer.php
- Description: The `getInstance` function of the installer class is now deprecated due some caching issues when installing multiple instances at once. Please instantiate always a new installer:
```php
// Old:
$installer = Installer::getInstance();

// New:
$installer = new Installer();
$installer->setDatabase($this->getDatabase());
```