tests: run insta --force-update-snapshots - #5888
Merged
Merged
Conversation
ilyagr
force-pushed
the
ig/insta-update-snapshots
branch
from
March 6, 2025 03:29
8b5190a to
45b113b
Compare
ilyagr
marked this pull request as ready for review
March 6, 2025 03:32
ilyagr
changed the title
insta --force-update-snapshotsinsta --force-update-snapshots, fixup formatter tests
ilyagr
force-pushed
the
ig/insta-update-snapshots
branch
from
March 6, 2025 03:36
45b113b to
49f19df
Compare
ilyagr
marked this pull request as draft
March 6, 2025 03:37
ilyagr
force-pushed
the
ig/insta-update-snapshots
branch
from
March 6, 2025 03:39
49f19df to
b9a0eec
Compare
ilyagr
marked this pull request as ready for review
March 6, 2025 03:39
ilyagr
force-pushed
the
ig/insta-update-snapshots
branch
2 times, most recently
from
March 6, 2025 03:45
5a8697f to
a8b1b23
Compare
Contributor
|
FYI, @jakobhellermann (since you wrote #5558). |
ilyagr
force-pushed
the
ig/insta-update-snapshots
branch
from
March 6, 2025 07:23
a8b1b23 to
d663f96
Compare
yuja
approved these changes
Mar 6, 2025
This is a replacement for #5558. Thanks to @yuja 's mitsuhiko/insta#722, this is now easy to generate.
ilyagr
force-pushed
the
ig/insta-update-snapshots
branch
from
March 6, 2025 21:20
d663f96 to
695a243
Compare
ilyagr
changed the title
insta --force-update-snapshots, fixup formatter testsinsta --force-update-snapshots
Contributor
Author
|
Thank you, Yuya! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #5558. See the discussion over there for an explanation of the first commit.
(That commit is a bit cavalier, I may have missed some sport)
Thanks to @yuja 's mitsuhiko/insta#722, the second commit is now easy to generate.
I'm sending this out now with #5887 to front-load various "large-scale changes", so that there is one large hurdle for rebasing different PRs instead of many small ones.