-
Notifications
You must be signed in to change notification settings - Fork 248
Comment accuracy: nine measured corrections (draft / experiment) #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
86f08e8
buffer.cpp: name the real bound behind the block-count divide
2b63f9a
buffer.cpp: correct the wrap-detection horizon: 128 counts, not 256
3a4a715
buffer.cpp: document the second loss channel beside the window move
64af334
client.cpp: non-zero iActiveChannels does not imply a server restart
3166c59
server.cpp: drop the outdated QtConcurrent 5-parameter rationale
d6e6658
server.cpp: state the real reason the disconnect flag needs no mutex
78ed25f
channel.cpp: comment the true per-packet overhead (measured 46/66 B, …
cca203b
server.cpp: comment that the realtime path still allocates (send-path…
731b309
client.cpp: comment that FindClientChannel here is not guaranteed to …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above is far too verbose for anyone to read it clearly. Two lines looks like a good length. Ten lines isn't.
It needs to be short and to the point: