Additional unit testing - #84
Merged
Merged
Conversation
…o it wouldn't prompt for keychain access while running tests
…utionPointTests that Claude gave up on and said the coverage is sufficient without it now that we added tests for the child objects
team-adder
Bot
requested review from
Leslie Helou (BIG-RAT),
Tyler Kerkhof (KapnKerk),
Mike Mello (mjKosmic) and
rydgecrakerjamf
March 31, 2026 15:36
Copilot started reviewing on behalf of
Harry Strand (HarryStrandJamf)
March 31, 2026 15:36
View session
Mike Mello (mjKosmic)
previously approved these changes
Apr 3, 2026
Tyler Kerkhof (KapnKerk)
previously approved these changes
Apr 14, 2026
Harry Strand (HarryStrandJamf)
dismissed stale reviews from Tyler Kerkhof (KapnKerk) and Mike Mello (mjKosmic)
via
April 14, 2026 19:33
8134d5d
…main actor Added unit tests for DpFile, DpFiles, and MultipartUpload. Refactored MultipartUpload to inject URLSessionProtocol for testability and removed stale commented-out parameters from awsSignature256.
rydgecrakerjamf
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.