test(e2e): repair 45 stale Playwright tests against current UI - #9
Merged
Conversation
The suite rotted as the UI evolved: comment strip below the diff was dead-coded in favor of the right-panel comments tab, the collapsible edges section became an annotation subtab, the flow graph moved behind the Graph subtab, file clicks now open tabs without selecting groups, the source explorer became outline-only, and a second branch dropdown broke strict-mode locators. Rewrote tests to cover the equivalent behavior in the current UI; deleted vacuous if(isVisible()) tests and duplicates. No app-code changes.
Review consensus fixes from OCR, over-engineering, and senior review passes: - Make vacuous tests real: mount the Graph subtab before asserting export buttons/minimap absence; check the comments badge without pre-opening the tab so glyph-click activation is actually exercised - Delete stale screenshot tests 61/63-66 (dead comment strip, moved edges toggle, graph captures owned by visual-polish and hardening) plus their orphaned pngs - Drop dead waitForTimeout sleeps subsumed by auto-retrying assertions, redundant double-asserts of single ternary branches, and implementation- detail class assertions - Scope .llm-loading and .annotation-subtab-count locators against future strict-mode collisions Suite: 204 passed, 2 skipped.
Owner
|
Thanks, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Playwright suite rotted as the UI evolved: the comment strip below the diff was dead-coded in favor of the right-panel comments tab, the collapsible edges section became an annotation subtab, the flow graph moved behind the Graph subtab, file clicks now open tabs without selecting groups, the source explorer became outline-only, and a second branch dropdown broke strict-mode locators.
if (isVisible())tests, stale screenshot tests for removed features, and duplicates (plus their orphaned pngs)docs/screenshots/*.pngbaselinesThe second commit applies fixes from a three-reviewer pass (rule-checklist, over-engineering, and senior review): made remaining vacuous assertions real (mount the graph before asserting absence of export buttons/minimap), dropped dead sleeps subsumed by Playwright's auto-retrying assertions, and scoped two strict-mode-fragile locators.
Test plan
Full suite on this branch rebased onto
main: