Add GitHub Actions for Ruff and Black, and make them green - #234
Draft
alanking wants to merge 4 commits into
Draft
Add GitHub Actions for Ruff and Black, and make them green#234alanking wants to merge 4 commits into
alanking wants to merge 4 commits into
Conversation
Based on recommendations in Ruff's documentation: https://docs.astral.sh/ruff/integrations/#github-actions
Based on recommendations in Black's documentation: https://black.readthedocs.io/en/stable/integrations/github_actions.html
alanking
marked this pull request as ready for review
November 14, 2024 15:54
alanking
marked this pull request as draft
November 14, 2024 16:03
This was referenced Nov 14, 2024
Member
|
ruff can do what black does, and much faster. do we need both? |
Contributor
Author
|
The official GitHub Action workflow for Ruff did not do any formatting nor did it report any formatting errors. Personally, I kind of like having them separated even if we do end up using Ruff for both. Keeps the concerns separated. Additionally, Ruff and Black differ in how they handle certain situations: https://github.com/astral-sh/ruff/blob/main/docs/formatter/black.md Perhaps it's a matter of configuration? |
Member
|
ah, i see - not identical. thanks. two is definitely fine - until/if/when we have a stronger opinion to collapse to just ruff. |
Contributor
Author
|
Noting for self: Waiting for #231 before merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #233
Can squash as desired and/or open issues for the different pieces of work.