[#478] Fix handling of plus (+) and use Boost.URL (main) - #511
Open
korydraughn wants to merge 3 commits into
Open
[#478] Fix handling of plus (+) and use Boost.URL (main)#511korydraughn wants to merge 3 commits into
korydraughn wants to merge 3 commits into
Conversation
korydraughn
commented
Aug 20, 2026
|
|
||
| // TODO Create a better name. | ||
| auto to_argument_list(const std::string_view _urlencoded_string) -> std::unordered_map<std::string, std::string>; | ||
| auto parse_urlencoded_data(const std::string_view _urlencoded_string) |
Contributor
Author
There was a problem hiding this comment.
Document that this implements the following.
Comment on lines
+202
to
+211
| auto parse_result = boost::urls::parse_origin_form(_req.target()); | ||
| if (!parse_result) { | ||
| const auto& ec = parse_result.error(); | ||
| logging::error( | ||
| "{}: Could not parse URL path [{}]; error code=[{}], message=[{}].", | ||
| __func__, | ||
| _req.target(), | ||
| ec.value(), | ||
| ec.message()); | ||
| THROW(SYS_LIBRARY_ERROR, "URL parse error"); |
Contributor
Author
There was a problem hiding this comment.
Trigger this code path to see what the log message looks like.
Or go look at the docs for error_code::value/::message.
Comment on lines
+738
to
+741
| collection = f'/{self.zone_name}/home/{self.rodsuser_username}/=issue+478' | ||
|
|
||
| try: | ||
| # Create a collection that has a "+" in its logical path. |
Contributor
Author
There was a problem hiding this comment.
The comment on L741 is for the path on L738. Consider moving the comment and adding more context.
trel
reviewed
Aug 20, 2026
| #include <boost/beast.hpp> | ||
| #include <boost/url.hpp> | ||
|
|
||
| #include <curl/curl.h> |
Contributor
Author
There was a problem hiding this comment.
Yes, for now. There are still a few places where we use libcurl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All non-OIDC tests pass.