[#509] Implement support for logical quotas (main) - #510
Open
korydraughn wants to merge 4 commits into
Open
Conversation
This commit introduces a new endpoint, /logical-quotas, which supports
the following operations:
- stat
- set_quota
- recalculate
korydraughn
commented
Aug 19, 2026
Comment on lines
+144
to
+147
| {"max_bytes", _e.max_bytes}, | ||
| {"max_objects", _e.max_objects}, | ||
| {"over_bytes", _e.over_bytes}, | ||
| {"over_objects", _e.over_objects} |
Contributor
Author
There was a problem hiding this comment.
Should these names change?
Member
There was a problem hiding this comment.
max -> maximum
and... perhaps switching the order of the 'overs'... but then sorting would not be clean.
- bytes_over
- objects_over
Contributor
Author
There was a problem hiding this comment.
max -> maximum -- done.
Still thinking about the names and presentation of this data.
Comment on lines
+219
to
+227
| const auto max_bytes_iter = _args.find("maximum-bytes"); | ||
| if (max_bytes_iter != std::end(_args)) { | ||
| input.arg2 = max_bytes_iter->second.c_str(); | ||
| } | ||
|
|
||
| const auto max_objects_iter = _args.find("maximum-objects"); | ||
| if (max_objects_iter != std::end(_args)) { | ||
| input.arg3 = max_objects_iter->second.c_str(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Should these names change?
maximum-bytesmaximum-objects
trel
reviewed
Aug 19, 2026
trel
left a comment
trel
left a comment
Member
There was a problem hiding this comment.
yes, a renaming of a couple things conversation should happen. otherwise, looks pretty good. i like how similar this is to the physical quotas.
Comment on lines
+144
to
+147
| {"max_bytes", _e.max_bytes}, | ||
| {"max_objects", _e.max_objects}, | ||
| {"over_bytes", _e.over_bytes}, | ||
| {"over_objects", _e.over_objects} |
Member
There was a problem hiding this comment.
max -> maximum
and... perhaps switching the order of the 'overs'... but then sorting would not be clean.
- bytes_over
- objects_over
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New tests pass.
All non-OIDC tests pass too.