Disable Node.js setup in CI workflows - #959
Merged
Merged
Conversation
traitlets has no JavaScript, so set node_version: "none" on the maintainer-tools base-setup action to skip installing node in the test and release workflows. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E4KrMceq44AzZCZfxt7sam
- Use uv for base-setup's pip operations (python_package_manager: "uv pip"). - Run free-threaded 3.14t on Linux only. The free-threaded build is not in the runner tool cache and is expensive to provision on Windows/macOS (~73s base-setup vs ~23s on Linux); Linux coverage is retained. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E4KrMceq44AzZCZfxt7sam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR disables Node.js installation across all CI/CD workflows by explicitly setting
node_version: "none"in thebase-setupaction configuration. This change optimizes CI performance by skipping unnecessary Node.js setup for Python-only projects.Changes Made
node_version: "none"parameter to alljupyterlab/maintainer-tools/.github/actions/base-setup@v1action calls across multiple workflows:tests.yml: 6 job configurations (test, test_minimum_versions, lint, docs, test_prerelease, build_sdist, test_sdist, check_links, check_release)prep-release.yml: 1 job configurationpublish-changelog.yml: 1 job configurationpublish-release.yml: 1 job configurationImplementation Details
https://claude.ai/code/session_01E4KrMceq44AzZCZfxt7sam