fix: basicnode.NewInt returns pointer (like others) - #525
Merged
Conversation
hacdias
marked this pull request as ready for review
June 16, 2023 08:01
3 tasks
rvagg
approved these changes
Jun 19, 2023
rvagg
left a comment
rvagg
left a comment
Member
There was a problem hiding this comment.
ack, good find, nice to have tests that expose this kind of thing!
Member
|
FYI @hacdias, I'm going to cut a release with this but I'm currently working through some traversal stuff that may either result in breaking changes or feature additions and I'd like to bundle that up in a larger release since we have a bunch of stuff backlogged. So I'll be getting there soon and this isn't forgotten (I now have untagged releases in my own go.mods which are uncomfortable so I'm alert to it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basicnode.NewIntshould return a pointer toplainInt, similarly to the other types (string, float, bytes, etc). When writing tests for this PR and mocking interfaces, I was getting a pretty interesting error: theDecodedversion of anintwas returning a*plainInt, while thebasicnode.NewIntwas returningplainInt, causing the mock to fail.All the other node types work well. There is an inconsistency between how ints are created and assigned. This does not happen with other types. I assume this was something overlooked. It would be nice if this could get released.
cc @rvagg