fix(gateway): do not convert unixfs/raw into dag-* unless explicit - #9565
Closed
hacdias wants to merge 2 commits into
Closed
fix(gateway): do not convert unixfs/raw into dag-* unless explicit#9565hacdias wants to merge 2 commits into
hacdias wants to merge 2 commits into
Conversation
hacdias
force-pushed
the
json-cbor-changes
branch
from
January 19, 2023 12:54
b0c6175 to
e2cf012
Compare
hacdias
changed the title
hacdias
changed the title
3 tasks
Member
Author
|
Superseded by #9566. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:: I also made an alternative version of this PR that includes less changes overall to achieve the same result #9566.
In the spirit of https://github.com/protocol/bifrost-infra/issues/2290 and ipfs/specs#328 (review), this PR removes IPLD Logical Format conversion via
?format=json|cbor(and respectiveAcceptheaders). Now we need to explicitly indicatedag-json|dag-cbor. The table of the output type for input\request combos:serveUnixFs)serveUnixFs)serveUnixFs)serveUnixFs)serveUnixFs)serveUnixFs)serveUnixFs)serveUnixFs)I'm not exactly confident that this is simpler than the implementation we had before, or if it is a good idea. I think we should keep being able to retrieve JSON and CBOR CIDs from the Gateway, as well as converting between both formats. Then, we cannot convert DAG-JSON and DAG-CBOR to JSON/CBOR because of the links that are not supported in regular JSON and CBOR.
The CI is failing on unrelated things that I did not change. It seems that there may be some NPM/Network errors.