Skip to content

fix: handle _redirects for If-None-Match headers #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidel merged 6 commits into from
Jul 25, 2023
Merged

fix: handle _redirects for If-None-Match headers #412

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97c8667
fix: handle _redirects for If-None-Match headers
aschmahmann Jul 18, 2023
267b14f
fix: handle _redirects for If-None-Match headers
aschmahmann Jul 18, 2023
b134654
Merge branch 'fix/gateway-redirects-non-get' of github.com:ipfs/go-li…
aschmahmann Jul 25, 2023
0ca10d9
fix(gateway): HEAD requests now respect _redirects
aschmahmann Jul 25, 2023
4f4f157
feat: add _redirects regression test
hacdias Jul 25, 2023
d9b38ab
docs: add changelog entry
hacdias Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions gateway/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,9 +700,19 @@ func (i *handler) handleIfNoneMatch(w http.ResponseWriter, r *http.Request, rq *
if ifNoneMatch := r.Header.Get("If-None-Match"); ifNoneMatch != "" {
pathMetadata, err := i.backend.ResolvePath(r.Context(), rq.immutablePath)
if err != nil {
err = fmt.Errorf("failed to resolve %s: %w", debugStr(rq.contentPath.String()), err)
i.webError(w, r, err, http.StatusInternalServerError)
return true
var forwardedPath ImmutablePath
var continueProcessing bool
if isWebRequest(rq.responseFormat) {
forwardedPath, continueProcessing = i.handleWebRequestErrors(w, r, rq.mostlyResolvedPath(), rq.immutablePath, rq.contentPath, err, rq.logger)
if continueProcessing {
pathMetadata, err = i.backend.ResolvePath(r.Context(), forwardedPath)
}
}
if !continueProcessing || err != nil {
err = fmt.Errorf("failed to resolve %s: %w", debugStr(rq.contentPath.String()), err)
i.webError(w, r, err, http.StatusInternalServerError)
return true
}
}

pathCid := pathMetadata.LastSegment.Cid()
Expand Down