Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

feat: add docker image - #11

Merged
lidel merged 1 commit into
mainfrom
feat/add-docker-image
Feb 8, 2023
Merged

feat: add docker image#11
lidel merged 1 commit into
mainfrom
feat/add-docker-image

Conversation

@lidel

@lidel lidel commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

This PR is based on #10

Borrows the most minimal set of conventions from Kubo and IPFS Cluster:

  • every commit on main branch is can be run via own image named main-YYYY-DD-MM-commit
  • we can also start doing releases in the future
    • git tags are translated to Docker tags with the same names (v0.0.0)
    • latest git tag is also tagged as latest and release

TODO

@lidel
lidel requested review from galargh and gmasgras February 4, 2023 02:29
@welcome

This comment was marked as resolved.

@lidel lidel added this to the M1: Feb 17 milestone Feb 4, 2023
@galargh

galargh commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

Did we end up agreeing on what DockerHub account to use? Is it the ipfsbot one? If so, I can set up the creds.

@hacdias
hacdias force-pushed the initial-iteration branch 4 times, most recently from a701342 to c912625 Compare February 7, 2023 15:08
@lidel

lidel commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator Author

@galargh yes, we will be using ipfsbot, publishing to https://hub.docker.com/r/ipfs/
If you can set up creds in this repo 🙏 , then I can rebase this PR, and we should be done.

Base automatically changed from initial-iteration to main February 8, 2023 04:02
@lidel
lidel force-pushed the feat/add-docker-image branch from 9bb38b8 to 686a47b Compare February 8, 2023 15:35
Borrows the most minimal set of conventions from Kubo and IPFS Cluster:
- git tags are translated to Docker tags with the same names
- every commit on main branch is tagged 'main-YYYY-DD-MM-commit'
@lidel
lidel force-pushed the feat/add-docker-image branch from 686a47b to a74d9b4 Compare February 8, 2023 15:42
@lidel
lidel marked this pull request as ready for review February 8, 2023 16:12
@lidel

lidel commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator Author

Rebased and set credentials to one from a vault shared with me. I suspect DOCKER_PASSWORD is outdated because it was not changed in the vault since 2021, but if the build in main fails to publish, we can update secret and re-run.

Merging to see how it behaves.

@lidel
lidel merged commit af343aa into main Feb 8, 2023
@lidel
lidel deleted the feat/add-docker-image branch February 8, 2023 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants