Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/actions/build-angular/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ runs:
with:
name: ionic-angular
output: ./packages/angular/AngularBuild.zip
paths: ./packages/angular/dist
paths: ./packages/angular/dist ./packages/angular/css
2 changes: 1 addition & 1 deletion .github/workflows/actions/build-core/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ runs:
output: core/CoreBuild.zip
# Include generated proxy files from Stencil output targets so
# framework builds can detect when they need to be updated
paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts core/api.txt packages/angular/src/directives/proxies.ts packages/angular/src/directives/proxies-list.ts packages/angular/standalone/src/directives/proxies.ts packages/vue/src/proxies.ts packages/react/src/components/proxies.ts packages/react/src/components/inner-proxies.ts packages/react/src/components/routing-proxies.ts
paths: core/dist core/components core/css core/hydrate core/loader core/src/components.d.ts core/api.txt packages/angular/src/lazy/directives/proxies.ts packages/angular/src/lazy/directives/proxies-list.ts packages/angular/src/standalone/directives packages/vue/src/proxies.ts packages/react/src/components/proxies.ts packages/react/src/components/inner-proxies.ts packages/react/src/components/routing-proxies.ts
1 change: 0 additions & 1 deletion .github/workflows/release-ionic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ jobs:
version: ${{ inputs.version }}
preid: ${{ inputs.preid }}
working-directory: 'packages/angular'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths: packages/angular/dist line just below is missing css. React and Vue both list dist and css, and build-angular/action.yml did get updated for it.

Low stakes since nothing actually downloads this particular archive, the CI path that does consume it is test-angular-e2e and that one's fine. Feel free to ignore, it's just inconsistent with the others.

folder: './dist'
- name: Cache Built @ionic/angular
uses: ./.github/workflows/actions/upload-archive
with:
Expand Down
7 changes: 4 additions & 3 deletions core/stencil.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ const getAngularOutputTargets = () => {
return [
angularOutputTarget({
componentCorePackage,
directivesProxyFile: '../packages/angular/lazy/src/directives/proxies.ts',
directivesArrayFile: '../packages/angular/lazy/src/directives/proxies-list.ts',
directivesProxyFile: '../packages/angular/src/lazy/directives/proxies.ts',
directivesArrayFile: '../packages/angular/src/lazy/directives/proxies-list.ts',
excludeComponents,
outputType: 'component',
}),
angularOutputTarget({
componentCorePackage,
directivesProxyFile: '../packages/angular/standalone/src/directives/proxies.ts',
directivesProxyFile: '../packages/angular/src/standalone/directives/proxies.ts',
excludeComponents: [
...excludeComponents,
/**
Expand All @@ -64,6 +64,7 @@ const getAngularOutputTargets = () => {

],
outputType: 'standalone',
esModules: true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is what makes Stencil emit the per-component files the rest of the PR hangs off, and there's nothing here saying so. Could you add a short comment? Someone tidying up this config later has no way to know it's load-bearing.

})
];
}
Expand Down
3 changes: 2 additions & 1 deletion packages/angular/.prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ dist
scripts
test
proxies.ts
lazy/src/directives/proxies-list.ts
src/lazy/directives/proxies-list.ts
src/standalone/directives/ion-*.ts
**/*/angular-component-lib/utils.ts
5 changes: 0 additions & 5 deletions packages/angular/common/ng-package.json

This file was deleted.

4 changes: 2 additions & 2 deletions packages/angular/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const tsConfigs = [...compat.extends('@ionic/eslint-config/recommended'), ...ang

module.exports = [
{
ignores: ['dist/**', 'build/**', 'scripts/**', '**/proxies.ts', 'test/**'],
ignores: ['dist/**', 'build/**', 'scripts/**', '**/proxies.ts', 'test/**', 'src/standalone/directives/ion-*.ts'],
},
...tsConfigs,
{
Expand All @@ -32,7 +32,7 @@ module.exports = [
// inferred project for them (the ts-eslint 8 equivalent of the old
// createDefaultProgram option).
projectService: {
allowDefaultProject: ['lazy/src/ionic-core.ts', 'schematics/add/*.ts', 'schematics/utils/*.ts'],
allowDefaultProject: ['src/lazy/ionic-core.ts', 'schematics/add/*.ts', 'schematics/utils/*.ts'],
},
tsconfigRootDir: __dirname,
},
Expand Down
5 changes: 0 additions & 5 deletions packages/angular/lazy/ng-package.json

This file was deleted.

7 changes: 0 additions & 7 deletions packages/angular/ng-package.json

This file was deleted.

Loading
Loading