-
Notifications
You must be signed in to change notification settings - Fork 13.3k
feat(angular): allow per-component standalone import paths for better code-splitting #31303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: major-9.0
Are you sure you want to change the base?
Changes from all commits
995f4c0
539e40b
fe5aaa8
26201b7
58bd658
5f68379
2d6e853
b5264c9
af46f51
75bc9f7
dbdd22e
f41b13b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,14 +30,14 @@ const getAngularOutputTargets = () => { | |
| return [ | ||
| angularOutputTarget({ | ||
| componentCorePackage, | ||
| directivesProxyFile: '../packages/angular/lazy/src/directives/proxies.ts', | ||
| directivesArrayFile: '../packages/angular/lazy/src/directives/proxies-list.ts', | ||
| directivesProxyFile: '../packages/angular/src/lazy/directives/proxies.ts', | ||
| directivesArrayFile: '../packages/angular/src/lazy/directives/proxies-list.ts', | ||
| excludeComponents, | ||
| outputType: 'component', | ||
| }), | ||
| angularOutputTarget({ | ||
| componentCorePackage, | ||
| directivesProxyFile: '../packages/angular/standalone/src/directives/proxies.ts', | ||
| directivesProxyFile: '../packages/angular/src/standalone/directives/proxies.ts', | ||
| excludeComponents: [ | ||
| ...excludeComponents, | ||
| /** | ||
|
|
@@ -64,6 +64,7 @@ const getAngularOutputTargets = () => { | |
|
|
||
| ], | ||
| outputType: 'standalone', | ||
| esModules: true, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line is what makes Stencil emit the per-component files the rest of the PR hangs off, and there's nothing here saying so. Could you add a short comment? Someone tidying up this config later has no way to know it's load-bearing. |
||
| }) | ||
| ]; | ||
| } | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
paths: packages/angular/distline just below is missingcss. React and Vue both listdistandcss, andbuild-angular/action.ymldid get updated for it.Low stakes since nothing actually downloads this particular archive, the CI path that does consume it is
test-angular-e2eand that one's fine. Feel free to ignore, it's just inconsistent with the others.