-
Notifications
You must be signed in to change notification settings - Fork 13.3k
feat(angular): allow per-component standalone import paths for better code-splitting #31303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OS-jacobbell
wants to merge
12
commits into
major-9.0
Choose a base branch
from
FW-6470
base: major-9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
995f4c0
feat(angular): allow per-component standalone import paths for better…
OS-jacobbell 539e40b
enable source maps
OS-jacobbell fe5aaa8
clean up package.json
OS-jacobbell 26201b7
update package-lock.json
OS-jacobbell 58bd658
update clean script
OS-jacobbell 5f68379
update eslint config
OS-jacobbell 2d6e853
update prettierignore
OS-jacobbell b5264c9
update ci build core action
OS-jacobbell af46f51
update build angular ci action
OS-jacobbell 75bc9f7
enable ngc compatibility mode
OS-jacobbell dbdd22e
explicitly export components
OS-jacobbell f41b13b
update release workflow
OS-jacobbell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is what makes Stencil emit the per-component files the rest of the PR hangs off, and there's nothing here saying so. Could you add a short comment? Someone tidying up this config later has no way to know it's load-bearing.