Skip to content

[SYCL][Test] Disable 2 failing tests on old libstdc++ via lit features#22562

Merged
againull merged 1 commit into
intel:sycl-webfrom
wenju-he:fix-device_only_no_iostream.cpp
Jul 7, 2026
Merged

[SYCL][Test] Disable 2 failing tests on old libstdc++ via lit features#22562
againull merged 1 commit into
intel:sycl-webfrom
wenju-he:fix-device_only_no_iostream.cpp

Conversation

@wenju-he

@wenju-he wenju-he commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Both tests fail on RHEL 8.8/gcc 8.5.

Add feature detection to sycl/test/lit.cfg.py, probing the predefined macros of the toolchain in use (modeled on libcxx's compilerMacros()):

  • glibcxx-ge-11: from _GLIBCXX_RELEASE, for device_only_no_iostream.cpp, whose root cause is <bits/stl_iterator.h> pulling in on older libstdc++.
  • cpp_lib_span: from __cpp_lib_span with -std=c++20, for negative_test.cpp, whose root cause is being unavailable on older libstdc++, not a C++20 language-mode issue.

CMPLRLLVM-76646

Both tests fail on RHEL 8.8/gcc 8.5.

Add feature detection to sycl/test/lit.cfg.py, probing the predefined
macros of the toolchain in use (modeled on libcxx's compilerMacros()):
- glibcxx-ge-11: from _GLIBCXX_RELEASE, for device_only_no_iostream.cpp,
  whose root cause is <bits/stl_iterator.h> pulling in <ostream> on
  older libstdc++.
- cpp_lib_span: from __cpp_lib_span with -std=c++20, for negative_test.cpp,
  whose root cause is <span> being unavailable on older libstdc++, not
  a C++20 language-mode issue.

CMPLRLLVM-76646

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@wenju-he wenju-he requested a review from a team as a code owner July 7, 2026 11:18
@wenju-he wenju-he requested review from againull and removed request for a team July 7, 2026 11:18
@againull againull merged commit 34a6495 into intel:sycl-web Jul 7, 2026
@wenju-he wenju-he deleted the fix-device_only_no_iostream.cpp branch July 8, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants