[SYCL] Remove stale code previously used for FPGA loop counts, fusion, and coalescence#22556
Open
tahonermann wants to merge 2 commits into
Open
[SYCL] Remove stale code previously used for FPGA loop counts, fusion, and coalescence#22556tahonermann wants to merge 2 commits into
tahonermann wants to merge 2 commits into
Conversation
…lescence Support for the [[intel::loop_coalesce]] and [[intel::nofusion]] attributes was previously removed by the following commits. - 3ee6128: [SYCL] PR 6 - Remove FPGA Attributes from SYCL FE (intel#21785) - 136b1cd: [SYCL] PR 1 - Remove FPGA attributes from SYCL FE (intel#21710) Removal of the attributes left a few data members and related setter functions unused. This change removes them.
Contributor
Author
|
@premanandrao, could you please review this PR? |
Fznamznon
approved these changes
Jul 7, 2026
premanandrao
reviewed
Jul 7, 2026
Support for the [[intel::loop_count(N)]], [[intel::loop_count_avg(N)]], [[intel::loop_count_min(N)]], and [[intel::loop_count_max(N)]] attributes was previously removed by the following commit. - 7102583: [SYCL] PR 2 - Remove FPGA attributes from SYCL FE (intel#21722) Removal of the attributes left a data member and related setter function with only inert uses left. This change removes them.
tahonermann
changed the title
Contributor
Author
|
@Fznamznon, @premanandrao, updates made; this is ready to be reviewed again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for the
[[intel::loop_count(N)]],[[intel::loop_count_avg(N)]],[[intel::loop_count_min(N)]],[[intel::loop_count_max(N)]],[[intel::loop_coalesce]], and[[intel::nofusion]]attributes was previously removed by the following commits.Removal of the attributes left a few data members and related setter functions unused. This change removes them.