Skip to content

[SYCL] Implement updates to the root group extension#22552

Open
lbushi25 wants to merge 15 commits into
intel:syclfrom
lbushi25:root_group_updates
Open

[SYCL] Implement updates to the root group extension#22552
lbushi25 wants to merge 15 commits into
intel:syclfrom
lbushi25:root_group_updates

Conversation

@lbushi25

@lbushi25 lbushi25 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Implement the updates made to the root group extension as described here: #21838

@lbushi25 lbushi25 changed the title [SYCL] Root group updates [SYCL] Implement updates to the root group extension Jul 6, 2026
@lbushi25

lbushi25 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@koparasy I see that my PR is causing the test https://github.com/intel/llvm/blob/1a6dd8c780643a46f6c9242516b845f2219b426c/sycl/test/include_deps/header_reach.cpp to fail. I have taken a look and I'm not sure why the fail is happening. My PR does not add any new #include lines. Is this an issue on my end or with the header_reach_check.py script?

@lbushi25

lbushi25 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@koparasy I see that my PR is causing the test https://github.com/intel/llvm/blob/1a6dd8c780643a46f6c9242516b845f2219b426c/sycl/test/include_deps/header_reach.cpp to fail. I have taken a look and I'm not sure why the fail is happening. My PR does not add any new #include lines. Is this an issue on my end or with the header_reach_check.py script?

For the logs, see: https://github.com/intel/llvm/actions/runs/28829463684/job/85499991921?pr=22552

@koparasy

koparasy commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@koparasy I see that my PR is causing the test https://github.com/intel/llvm/blob/1a6dd8c780643a46f6c9242516b845f2219b426c/sycl/test/include_deps/header_reach.cpp to fail. I have taken a look and I'm not sure why the fail is happening. My PR does not add any new #include lines. Is this an issue on my end or with the header_reach_check.py script?

For the logs, see: https://github.com/intel/llvm/actions/runs/28829463684/job/85499991921?pr=22552

You are having compilation errors sycl/include/sycl/kernel.hpp when a TU includes this file. Basically, the header file is not including everything it needs to be self contained.

@lbushi25 lbushi25 marked this pull request as ready for review July 7, 2026 02:16
@lbushi25 lbushi25 requested a review from a team as a code owner July 7, 2026 02:16
@lbushi25 lbushi25 requested a review from cperkinsintel July 7, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants