[SYCL][E2E] Add SYCL E2E test to cover marray operations on device#22543
Open
uditagarwal97 wants to merge 1 commit into
Open
[SYCL][E2E] Add SYCL E2E test to cover marray operations on device#22543uditagarwal97 wants to merge 1 commit into
uditagarwal97 wants to merge 1 commit into
Conversation
uditagarwal97
changed the title
| if constexpr (std::is_same_v<T, bool>) | ||
| Ret[I] = (I % 2 == 0); | ||
| else | ||
| Ret[I] = T(I + 1); // 1,2,3,... |
Contributor
There was a problem hiding this comment.
are this test and comments AI-generated? some comments are pretty useless here, would be nice to remove such comments. Also if it is assisted with AI - you'd need to mention it in PR description
| auto B = makeB<T, N>(); | ||
| T Scalar = T(2); | ||
| auto ExpectedRhs = A; | ||
| Op(ExpectedRhs, B); |
Contributor
There was a problem hiding this comment.
nit: tests do same actions on host and on device, then check equality. Is there a good way to unify these actions between host & device then? Otherwise any update of test scenario will require 2 places to be updated.
| checkAssign<int, 4>(Q, [](auto &X, auto Y) { X += Y; }); | ||
| checkAssign<int, 4>(Q, [](auto &X, auto Y) { X &= Y; }); | ||
|
|
||
| // half: storeVecResult convert branch (half -> _Float16), vector path only. |
Contributor
There was a problem hiding this comment.
kind of misleading comments, this test doesn't contain storeVecResult. I assume it is SYCL implementation-detail method. do we really need to link E2E test comments to implementation-detailed stuff?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve marray's code coverage.