Skip to content

[SYCL] Don't include OpenCL headers when compiling for device#22533

Open
uditagarwal97 wants to merge 5 commits into
syclfrom
private/udit/cleanOCLTypes-3
Open

[SYCL] Don't include OpenCL headers when compiling for device#22533
uditagarwal97 wants to merge 5 commits into
syclfrom
private/udit/cleanOCLTypes-3

Conversation

@uditagarwal97

@uditagarwal97 uditagarwal97 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

IGC wants the ability to compile SYCL device code and they don't have OpenCL headers installed. OpenCL headers are anyway not used when compiling for device.

@uditagarwal97 uditagarwal97 self-assigned this Jul 3, 2026
Base automatically changed from private/udit/cleanOCLTypes-2 to sycl July 6, 2026 23:05
@uditagarwal97 uditagarwal97 force-pushed the private/udit/cleanOCLTypes-3 branch from a3460c7 to c00071f Compare July 6, 2026 23:19
@uditagarwal97 uditagarwal97 marked this pull request as ready for review July 6, 2026 23:19
@uditagarwal97 uditagarwal97 requested review from a team as code owners July 6, 2026 23:19
@uditagarwal97 uditagarwal97 requested a review from againull July 6, 2026 23:19
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner July 6, 2026 23:59
@uditagarwal97 uditagarwal97 requested a review from mmichel11 July 6, 2026 23:59
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner July 7, 2026 05:25

@adamfidel adamfidel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graph test LGTM

@uditagarwal97

Copy link
Copy Markdown
Contributor Author

@intel/unified-runtime-reviewers-level-zero @intel/llvm-reviewers-runtime @againull ping

@koparasy

koparasy commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@uditagarwal97 Customers who relied on sycl.hpp transitively pulling in <CL/cl.h> etc. will get compile time errors.

I have deleted till now a couple of transitive headers and usually (because of downstream regressions who start filling tickets) I come back and add an inclusion here.

No strong opinions here though.

@uditagarwal97

Copy link
Copy Markdown
Contributor Author

@uditagarwal97 Customers who relied on sycl.hpp transitively pulling in <CL/cl.h> etc. will get compile time errors.

I have deleted till now a couple of transitive headers and usually (because of downstream regressions who start filling tickets) I come back and add an inclusion here.

No strong opinions here though.

@koparasy I agree, that's why several E2E tests are failing, because they were relying on SYCL headers to bring in OpenCL ones. With that said, SYCL Spec doesn't require us to provide OpenCL headers, and only those customers that uses OpenCL types, functions in their applications but relying on SYCL headers to pull in OpenCL ones will be affected.
The impact is limited IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants