[SYCL] add dx12 read write unsampled test of bindless images#22524
Closed
dklochkov-emb wants to merge 3 commits into
Closed
[SYCL] add dx12 read write unsampled test of bindless images#22524dklochkov-emb wants to merge 3 commits into
dklochkov-emb wants to merge 3 commits into
Conversation
dyniols
requested changes
Jul 7, 2026
dyniols
left a comment
dyniols
left a comment
Contributor
There was a problem hiding this comment.
Test sycl/test-e2e/bindless_images/dx12_interop/read_write_unsampled.cpp has been replaced and there were added new DX12 interop tests that are using new common d3d12_setup.hpp. New tests are https://github.com/intel/llvm/tree/sycl/sycl/test-e2e/bindless_images/dx12_interop
I think read_write_unsampled.cpp cases should be covered by the new interop tests, so I don’t see the need for a separate test, especially without a shared common setup. If you think adding this test is still worthwhile, you could try adjusting the current implementation to match the new DX12 interop tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bindless images read write unsampled test contained bug: L0 UR adapter could start process data earlier than DX12 prepared them to pass. As a result D2 and D3 tests failed doe to 0s passed to L0 UR adapter.
This PR adds test to avoid this synchronization problem.