fix: require Node.js 24 for native updater - #1414
Open
carbon-teq wants to merge 1 commit into
Open
Conversation
ilysenko
requested changes
Sep 1, 2026
ilysenko
left a comment
Owner
There was a problem hiding this comment.
Thanks for improving native updater reliability. Two issues block this change:
- Skipping the Debian service stop leaves the old executable running after replacement.
current_exe()then returns a path ending in(deleted);builder.rspasses it asUPDATER_BINARY_SOURCE, andensure_updater_binaryrejects the next rebuild. I reproduced this with the real packaging helper. Please move the independent Debian lifecycle change, its test and documentation to a subsequent PR. That fix needs safe process refresh after state persistence and a regression test covering the next rebuild. Requires: nodejs >= 24does not enforce the runtime floor on Fedora: its epoch-1 Node 22 package satisfies this dependency, while the updater rejects/usr/bin/node22. Make the dependency and selected runtime consistent across supported RPM distributions, with coverage rejecting Node 22 and accepting supported Node 24 providers. Do not assume a single epoch across distributions.
Please run the complete updated base-to-head diff through your own code-review model, fix every blocker it finds, rerun the review, and repeat until it reports no remaining blockers before requesting maintainer re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation