fix(computer-use): use terminal paste shortcuts on KDE Plasma - #1413
fix(computer-use): use terminal paste shortcuts on KDE Plasma#1413thisisryanswift wants to merge 2 commits into
Conversation
ilysenko
left a comment
There was a problem hiding this comment.
Thanks for improving KDE terminal paste and preserving the input guards. Please fix these two regressions before merge:
-
In computer-use-linux/src/server.rs:4843, preserve ordinary GUI-field paste inside terminal windows. Konsole's Find field is a QLineEdit, but window identity now selects Ctrl+Shift+V instead of its working Ctrl+V. Use the actual input focus when selecting the shortcut and add coverage for the terminal view versus Find in the same window.
-
In computer-use-linux/src/terminal.rs:239, preserve Ghostty PTY detection with a custom X11 class. The default instance remains ghostty, which the new exact identity list omits. With a non-brand shell title, the same one-window/one-PTY fixture gets metadata on base and none on head, breaking terminal selectors. Retain this identity and add an enrichment regression test.
Please run the complete updated base-to-head diff through your own code-review model, fix every blocker it finds, rerun the review, and repeat until the model reports no remaining blockers before requesting maintainer re-review.
Transparently, agent/ai generated, but real issue I was having. Feel free to reject as needed!
Summary
Validation
cargo fmt -p codex-computer-use-linux -- --checkcargo test --locked -p codex-computer-use-linux kde_clipboard_cargo test --locked -p codex-computer-use-linux terminal_pastecargo test --locked -p codex-computer-use-linux --lib- 274 passedcargo clippy --locked -p codex-computer-use-linux --lib -- -D warnings