Skip to content

fix(computer-use): use terminal paste shortcuts on KDE Plasma - #1413

Open
thisisryanswift wants to merge 2 commits into
ilysenko:mainfrom
thisisryanswift:fix/kde-terminal-paste-embedded
Open

fix(computer-use): use terminal paste shortcuts on KDE Plasma#1413
thisisryanswift wants to merge 2 commits into
ilysenko:mainfrom
thisisryanswift:fix/kde-terminal-paste-embedded

Conversation

@thisisryanswift

@thisisryanswift thisisryanswift commented Aug 31, 2026

Copy link
Copy Markdown

Transparently, agent/ai generated, but real issue I was having. Feel free to reject as needed!

Summary

Validation

  • cargo fmt -p codex-computer-use-linux -- --check
  • cargo test --locked -p codex-computer-use-linux kde_clipboard_
  • cargo test --locked -p codex-computer-use-linux terminal_paste
  • cargo test --locked -p codex-computer-use-linux --lib - 274 passed
  • cargo clippy --locked -p codex-computer-use-linux --lib -- -D warnings
  • independent code review: no findings

@thisisryanswift
thisisryanswift marked this pull request as ready for review August 31, 2026 18:24
@thisisryanswift
thisisryanswift marked this pull request as draft August 31, 2026 18:27
@thisisryanswift
thisisryanswift marked this pull request as ready for review August 31, 2026 18:52

@ilysenko ilysenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving KDE terminal paste and preserving the input guards. Please fix these two regressions before merge:

  1. In computer-use-linux/src/server.rs:4843, preserve ordinary GUI-field paste inside terminal windows. Konsole's Find field is a QLineEdit, but window identity now selects Ctrl+Shift+V instead of its working Ctrl+V. Use the actual input focus when selecting the shortcut and add coverage for the terminal view versus Find in the same window.

  2. In computer-use-linux/src/terminal.rs:239, preserve Ghostty PTY detection with a custom X11 class. The default instance remains ghostty, which the new exact identity list omits. With a non-brand shell title, the same one-window/one-PTY fixture gets metadata on base and none on head, breaking terminal selectors. Retain this identity and add an enrichment regression test.

Please run the complete updated base-to-head diff through your own code-review model, fix every blocker it finds, rerun the review, and repeat until the model reports no remaining blockers before requesting maintainer re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants