IBX-12091: Added TypeScript translation extraction support by mikadamczyk · Pull Request #1967 · ibexa/admin-ui

mikadamczyk · 2026-07-16T07:44:47Z

🎫 Issue	IBX-12091

Description:

This PR adds TypeScript translation extraction support for Translator.trans() and Translator.transChoice() calls, including translation descriptions from @Desc comments. The extractor uses a persistent Node.js process with runtime validation, response timeouts, error handling, and automatic restart after failures. The implementation separates the JMS visitor from process management and installs frontend dependencies in the backend CI job so the tests can run correctly.

For QA:

Documentation:

sonarqubecloud · 2026-07-20T13:50:42Z

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

konradoboza

Nice one!

konradoboza · 2026-07-21T11:55:26Z

+use Symfony\Component\Process\InputStream;
+use Symfony\Component\Process\Process;
+
+final class TypeScriptExtractorClient


Suggested change

final class TypeScriptExtractorClient

final readonly class TypeScriptExtractorClient

konradoboza · 2026-07-21T11:55:33Z

+
+final class TypeScriptExtractorClient
+{
+    private const DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0;


Suggested change

private const DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0;

private const float DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0;

konradoboza · 2026-07-21T11:55:53Z

+        $this->parserScriptPath = $parserScriptPath ?? __DIR__ . '/typescript_translation_extractor.mjs';
+    }
+
+    public function __destruct()


Can this have a return type?

konradoboza · 2026-07-21T11:57:48Z

+use SplFileInfo;
+use Twig\Node\Node as TwigNode;
+
+final class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface


Suggested change

final class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface

final readonly class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface

konradoboza · 2026-07-21T11:59:22Z

+     * @param array<mixed> $ast
+     */
+    public function visitPhpFile(SplFileInfo $file, MessageCatalogue $catalogue, array $ast): void
+    {


Should we provide a comment why it is empty? 😉 Same goes for the Twig below.

wiewiurdp · 2026-07-21T12:08:20Z

+
+    public function testServeModeProcessesMultipleFilesSequentiallyAndSurvivesPerFileErrors(): void
+    {
+        $goodFile = tempnam(sys_get_temp_dir(), 'ts_extractor_') . '.ts';


tempnam() creates the file immediately. Appending .ts only modifies the returned path, so file_put_contents() creates a second file and the original temporary file is never removed. Could we rename the file instead, as done in testExtractsExpectedMessages()? The same applies to the other tempnam(...).'.ts' occurrences.

barw4 · 2026-07-22T08:26:26Z

+
+        foreach ($warnings as $warning) {
+            if (is_string($warning)) {
+                $this->logger?->error($warning);


Nitpick but shouldn't it be warning per method's name and variables' names?

barw4 · 2026-07-22T08:27:39Z

+                $extractionResponse['error'],
+            ));
+
+            return null;


Would it make sense to narrow down the return type to an empty array since the method's name implies messages? In this case we won't need check from line 40.

alongosz

SonarQube analysis is relevant to the changes and should be addressed. It doesn't mean it's correct. In some cases (maybe even most) it's false-positive, but then it needs to be marked as such, so we don't miss a relevant one.

For that reason putting this in "request changes" state.

Some of the issues might require Front-end Team input.

Summary of that + my own findings:

alongosz · 2026-07-23T07:46:36Z

            satis-network-key: ${{ secrets.SATIS_NETWORK_KEY }}
            satis-network-token: ${{ secrets.SATIS_NETWORK_TOKEN }}

+      - uses: actions/setup-node@v4


outdated action version

Suggested change

- uses: actions/setup-node@v4

- uses: actions/setup-node@v7

alongosz · 2026-07-23T07:46:56Z

              satis-network-key: ${{ secrets.SATIS_NETWORK_KEY }}
              satis-network-token: ${{ secrets.SATIS_NETWORK_TOKEN }}

+      -   uses: actions/setup-node@v4


Suggested change

- uses: actions/setup-node@v4

- uses: actions/setup-node@v7

alongosz · 2026-07-23T07:47:07Z

              satis-network-key: ${{ secrets.SATIS_NETWORK_KEY }}
              satis-network-token: ${{ secrets.SATIS_NETWORK_TOKEN }}

+      -   uses: actions/setup-node@v4


Suggested change

- uses: actions/setup-node@v4

- uses: actions/setup-node@v7

alongosz · 2026-07-23T07:50:39Z

+            node-version: '24'
+
+      - name: Install frontend dependencies
+        run: yarn install


SonarQube:

Lifecycle scripts are enabled by default in Yarn v2+.
See more on https://sonarcloud.io/project/issues?id=ibexa_admin-ui&issues=AZ9_yweGtPeG6EAUOR9u&open=AZ9_yweGtPeG6EAUOR9u&pullRequest=1967

This looks relevant to the case, but if it's false positive, please mark it as false positive. I'm not able to assess this one on my own.

(you can use GitHub to log in to Sonar, so you can access full report, lmk if you have questions)

alongosz · 2026-07-23T07:52:52Z

+};
+
+const extractFromFile = (filePath) => {
+    const source = fs.readFileSync(filePath, 'utf8');


SonarQube:

LLMs running this code with faulty CLI arguments can escape file system restrictions. Refactor this code to validate the constructed path before accessing the file system.

This is an interesting one, I think we might LLM assessment on that :D

alongosz · 2026-07-23T07:55:28Z

+namespace Ibexa\AdminUi\Translation\Extractor;
+
+use JsonException;
+use RuntimeException;


If this is run in CLI, then one of Symfony\Console\ exceptions should be used.

Comes from SonarQube analysis, but I find this valid.

alongosz · 2026-07-23T08:00:21Z

+    {
+        if ($this->isRuntimeReady) {
+            return;
+        }


Architecture: is there a better way of checking readiness? For e.g., existence of some file?

This creates stateful service, which tends to cause problems and is not reliable really, as it lives in the current process memory only

it doesn't check if the runtime did its job.

I don't have a solution, because I don't know what this runtime does, but maybe it's worth looking into.

alongosz · 2026-07-23T08:03:13Z

+    {
+    }


Add a nested comment explaining why this method is empty, throw an Exception or complete the implementation.

Not just SonarQube idea, we've been actually practicing this elsewhere, if spotted.

alongosz · 2026-07-23T08:03:21Z

+    public function visitTwigFile(SplFileInfo $file, MessageCatalogue $catalogue, TwigNode $ast): void
+    {
+    }


IBX-12091: Added TypeScript translation extraction support

a6c9b07

github-actions Bot assigned ciastektk, mikadamczyk, ViniTou and dew326 Jul 16, 2026

mikadamczyk added 4 commits July 16, 2026 10:15

IBX-12091: Improved TypeScript translation extractor structure

8a5efda

IBX-12091: Simplified runtime readiness state

f1532dc

IBX-12091: Clarified TypeScript extractor naming

2d44f1c

IBX-12091: Installed frontend dependencies for backend tests

8b44786

mikadamczyk force-pushed the feature/IBX-12091-typescript-translation-extraction branch from 5198656 to 8b44786 Compare July 16, 2026 08:51

mikadamczyk marked this pull request as ready for review July 20, 2026 10:19

GrabowskiM requested changes Jul 20, 2026

View reviewed changes

albozek requested a review from GrabowskiM July 20, 2026 13:31

GrabowskiM approved these changes Jul 20, 2026

View reviewed changes

Comment thread src/lib/Translation/Extractor/typescript_translation_extractor.mjs

After cr

8b9bbb0

albozek force-pushed the feature/IBX-12091-typescript-translation-extraction branch from 26d6cc2 to 8b9bbb0 Compare July 20, 2026 13:49

mikadamczyk requested a review from a team July 21, 2026 11:40

ibexa-workflow-automation-1 Bot requested review from Steveb-p, ViniTou, alongosz, barw4, bnowak, ciastektk, konradoboza, tbialcz and wiewiurdp and removed request for a team July 21, 2026 11:40

konradoboza approved these changes Jul 21, 2026

View reviewed changes

wiewiurdp reviewed Jul 21, 2026

View reviewed changes

wiewiurdp approved these changes Jul 21, 2026

View reviewed changes

barw4 approved these changes Jul 22, 2026

View reviewed changes

alongosz requested changes Jul 23, 2026

View reviewed changes

	final class TypeScriptExtractorClient
	final readonly class TypeScriptExtractorClient

	private const DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0;
	private const float DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0;

	final class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface
	final readonly class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface

Uh oh!

Conversation

mikadamczyk commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

For QA:

Documentation:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jul 20, 2026

Quality Gate failed

Uh oh!

konradoboza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barw4 Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alongosz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

mikadamczyk commented Jul 16, 2026 •

edited

Loading

barw4 Jul 22, 2026 •

edited

Loading