Skip to content

IBX-11369: [Product picker] Filter issues #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OstafinL wants to merge 1 commit into
base: 4.6
Choose a base branch
from
Open

IBX-11369: [Product picker] Filter issues #1951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bundle/Resources/public/js/scripts/core/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const { dangerouslySetInnerHTML, dangerouslyInsertAdjacentHTML } = ibexa.helpers.dom;

const EVENT_VALUE_CHANGED = 'change';
const RESTRICTED_AREA_ITEMS_CONTAINER = 190;
const RESTRICTED_AREA_ITEMS_CONTAINER = 90;
const MINIMUM_LETTERS_TO_FILTER = 3;

class DropdownPopover extends bootstrap.Popover {
Expand Down
7 changes: 4 additions & 3 deletions src/bundle/Resources/public/scss/_dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@
padding-left: calculateRem(8px);
padding-top: 0;
padding-bottom: 0;
margin-right: calculateRem(8px);
max-width: calculateRem(380px);
margin-right: calculateRem(6px);
max-width: 100%;
transition: all $ibexa-admin-transition-duration $ibexa-admin-transition;

&--has-icon {
Expand Down Expand Up @@ -467,7 +467,8 @@
&--overflow {
.ibexa-dropdown {
&__selected-item {
max-width: calc(100% - #{calculateRem(40px)});
max-width: calc(100% - #{calculateRem(50px)});
transition: none;
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions src/bundle/Resources/public/scss/ui/modules/universal-discovery/_filters-panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.c-filters-panel {
@include c-filters-panel('.c-filters-row');

.ibexa-btn {
margin-left: calculateRem(4px);
}
}
3 changes: 2 additions & 1 deletion src/bundle/ui-dev/src/modules/common/dropdown/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const MIN_SEARCH_ITEMS_DEFAULT = 5;
const MIN_ITEMS_LIST_HEIGHT = 150;
const ITEMS_LIST_WIDGET_MARGIN = 8;
const ITEMS_LIST_SITE_MARGIN = ITEMS_LIST_WIDGET_MARGIN + 4;
const RESTRICTED_AREA_ITEMS_CONTAINER = 190;
const RESTRICTED_AREA_ITEMS_CONTAINER = 90;

const Dropdown = ({
dropdownListRef,
Expand Down Expand Up @@ -44,6 +44,7 @@ const Dropdown = ({
'ibexa-dropdown--small': small,
'ibexa-dropdown--disabled': disabled,
'ibexa-dropdown--expanded': isExpanded,
'ibexa-dropdown--overflow': overflowItemsCount > 0,
[extraClasses]: true,
});
const toggleExpanded = () => {
Expand Down
Loading