fix: resolve panic when UserType appears as struct member#1924
Open
mansiverma897993 wants to merge 1 commit into
Open
fix: resolve panic when UserType appears as struct member#1924mansiverma897993 wants to merge 1 commit into
mansiverma897993 wants to merge 1 commit into
Conversation
mansiverma897993
requested review from
salaheldinsoliman and
seanyoung
as code owners
Signed-off-by: mansiverma897993 <vmansi756@gmail.com>
mansiverma897993
force-pushed
the
fix-usertype-struct-panic
branch
from
9f44ce8 to
108fa15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an internal compiler panic that occurred when a user-defined value type (such as
type C is address;) was used as a member of a struct (fixes #1920).Root Cause
During semantic analysis for target Solana, layout and alignment calculations are performed on struct fields. However,
Type::storage_alignandType::align_ofinsrc/sema/types.rsdid not handle theType::UserTypevariant, triggering the fallback wildcard panic (unimplemented!()).Fix
Type::UserType(no)inType::storage_alignby recursing into its underlying resolved type: