feat(soroban): implement get/set storage bytes subscript#1918
Open
aryanbaranwal001 wants to merge 8 commits into
Open
feat(soroban): implement get/set storage bytes subscript#1918aryanbaranwal001 wants to merge 8 commits into
aryanbaranwal001 wants to merge 8 commits into
Conversation
… and codec Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
…alues Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
…, bytes32 Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
…bytes_subscript Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
Signed-off-by: Aryan Baranwal <aryanbaranwal131214@gmail.com>
Author
|
This PR is continuation of the work in #1908 and depends on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for reading or writing a particular byte of a
bytesstate variable on soroban by implementing previously stubbed functions ofget_storage_bytes_subscriptandset_storage_bytes_subscriptwithunimplemented!insoroban/target.rs.The following contract now compiles to a valid WASM binary
Key Changes
codegen/mod.rs: addedBytesGetandBytesPutvariants toHostFunctions& their"b.6"/"b.5"name mappings.emit/soroban/mod.rs: addedBytesGetandBytesPutarms tofunction_signature, and addedBytesLen/BytesGet/BytesPutto thedeclare_externalshost_functions list.emit/soroban/target.rs: implementedget_storage_bytes_subscriptandset_storage_bytes_subscript.Tests
tests/soroban_testcases/bytes_subscript.rscovering read at every index, boundary writes, write isolation against unrelated bytes, sequential writes at the same index, and three out-of-the-bounds trap cases.