[DistillationTrainer refactor] Emit prompt_ids / prompt_mask / completion_ids#6487
Open
qgallouedec wants to merge 4 commits into
Open
[DistillationTrainer refactor] Emit prompt_ids / prompt_mask / completion_ids#6487qgallouedec wants to merge 4 commits into
qgallouedec wants to merge 4 commits into
Conversation
63 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b38280e33a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 20 (Group B) — stacked on PR 19. Part of #6449.
Third step of the layout migration (add → switch → delete). Emit GRPO's keys alongside the existing ones; nothing consumes them yet (item 21 switches consumers, item 22 deletes the old helpers).
prompt_ids(=prompts),prompt_mask(=prompt_attention_mask), andcompletion_ids(the completion region ofinput_ids; empty for the prompt-only collator).New test asserts
cat(prompt_ids, completion_ids) == input_idsand that the prompt keys mirror the existing tensors.Verified: 53 tests pass (distillation + server); ruff clean.
Note
Low Risk
Additive tensor aliases on batch dicts with no consumer changes; behavior is covered by a new test asserting key parity with existing tensors.
Overview
Adds GRPO-aligned batch keys to
DistillationTrainerwhile keepingprompts/prompt_attention_maskunchanged—part of a layout migration (add → switch consumers → remove old keys).The collator and both on-policy generation paths (
model.generateand vLLM buffer updates) now includeprompt_ids(same asprompts),prompt_mask(same asprompt_attention_mask), andcompletion_ids(the completion slice ofinput_ids; for prompt-only collation this slice is empty). Nothing in the trainer reads these keys yet.A new integration test checks the keys are present on the batch passed to
compute_lossand thattorch.cat([prompt_ids, completion_ids], dim=1)matchesinput_ids.Reviewed by Cursor Bugbot for commit 77712c0. Bugbot is set up for automated code reviews on this repo. Configure here.