Fix vLLM server-mode communicator initialization to use the current A…#6417
Merged
Conversation
…ccelerator device instead of always querying CUDA. Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Contributor
Author
|
@qgallouedec please help review |
Contributor
Author
|
@IlyasMoutawwakil please help review |
kashif
enabled auto-merge (squash)
July 21, 2026 10:44
Member
|
@qgallouedec please merge when you can 🙏 |
kashif
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ccelerator device instead of always querying CUDA.
What does this PR do?
Fixes # (issue)
Before submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Note
Low Risk
One-line device argument change in server-mode initialization only; no auth, data, or broad behavioral refactors.
Overview
In vLLM server mode, weight-sync communicator setup now passes
accelerator.deviceintoVLLMClient.init_communicatorinstead oftorch.cuda.current_device().That matches the device Accelerate assigned for the training main process, so server-mode weight updates work on non-CUDA backends (and stay correct when CUDA index and Accelerate’s device differ).
Reviewed by Cursor Bugbot for commit a78ca1a. Bugbot is set up for automated code reviews on this repo. Configure here.