[serge] Fix 22 integration tests for model whisper failing with other (other (20), shape/size mismatch (2))#47056
Open
sergereview[bot] wants to merge 1 commit into
Open
Conversation
…her` (other (20), shape/size mismatch (2))
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: whisper |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
1/1: 22 integration tests for modelwhisperfailing withother(other (20), shape/size mismatch (2))tests/models/whisper/test_modeling_whisper.py::WhisperModelIntegrationTests::test_distil_token_timestamp_generation[multi-gpu] (other, seen 7/7)Relates to #47053
The Whisper integration tests fail with
UnboundLocalError: local variable 'is_updated' referenced before assignment(and cascading errors) becauseWhisperAttention.forwardonly definesis_updatedinside theisinstance(past_key_values, EncoderDecoderCache)branch. When a different cache type is used, the variable is undefined and the subsequent cross-attention reuse check crashes.Root cause: missing initialization of
is_updatedbefore the conditional, unlike the equivalent code in bart and other encoder-decoder models.Patch: add
is_updated = Falsebefore theEncoderDecoderCachecheck inWhisperAttention.forwardso the fallback path behaves correctly for non-EncoderDecoderCache caches.This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 53 LLM turns · 60 tool calls · 111.0s · 2093703 in / 4990 out tokens