[FR] Fix grammar and translation errors in chapter2/5 - #1295
Open
IROFI wants to merge 5 commits into
Open
Conversation
`gérer` takes a direct object, so the partitive `de` is ungrammatical here.
Matches the English source ("How do we handle multiple sequences?") and the
section title, which already says "Manipulation de plusieurs séquences".
"Les transformers acceptent en entrée que des séquences d'une longueur limitée" drops the `ne` of the restrictive `ne ... que`. Omitting it is common in spoken French but incorrect in writing, and it leaves the sentence reading as a plain affirmative until the reader reaches `que`. English source: "With Transformer models, there is a limit to the lengths of the sequences we can pass the models."
The backticked identifier refers to the `sequence` variable defined in the code snippet just above, so translating it to `séquence` breaks the link with the code the sentence is describing.
…choué ?" A direct question in written French needs the inversion; "Pourquoi cela a échoué ?" belongs to the spoken register.
The English question is idiomatic: "Is there such a thing as too long a sequence?" -- it asks whether a sequence *can* be too long. The literal "existe-t-il une séquence trop longue ?" reads as "does one particular over-long sequence exist?", which is not the question the section answers. "Une séquence peut-elle être trop longue ?" keeps the meaning and matches the "Séquences plus longues" section it points to.
Author
|
@lewtun @stevhliu for review, and @lbourdois as the maintainer of the French translation — this one needs a native-speaker call, in particular on line 40 ( |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six line fixes in
chapters/fr/chapter2/5.mdx. No line added or removed, no code snippet touched.The intro question list
gérertakes a direct object, the partitivedeis ungrammaticalThe third bullet ("les indices du vocabulaire sont-ils les seules entrées…") is a faithful translation and is left as is.
On line 40: the English is idiomatic — "Is there such a thing as too long a sequence?" asks whether a sequence can be too long. The literal French reads as "does one particular over-long sequence exist?", which is not the question the "Séquences plus longues" section goes on to answer. Worth noting that
es,itandptmade the same literal choice, so a French reviewer may well prefer to keep it — happy to drop this one commit if so.Three other errors in the same file
neof the restrictivene … quewas missing; dropping it is common in speech but incorrect in writing`séquence``sequence`sequencevariable defined in the snippet above, so it must not be translatedVerification
chapters/frwithdoc-builder build --html— builds clean, and the rendered list and snippet were checked against the page.make qualityreports the same result asmain(pre-existing failures, from a newerblackthan the one pinned in CI).