Fix List item_type validation rejecting subclasses with a custom metaclass - #1166
Open
maximlt wants to merge 2 commits into
Open
Fix List item_type validation rejecting subclasses with a custom metaclass#1166maximlt wants to merge 2 commits into
maximlt wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
=======================================
Coverage 86.73% 86.73%
=======================================
Files 9 9
Lines 5321 5321
=======================================
Hits 4615 4615
Misses 706 706 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_validate_item_typeusedtype(v) is not typeto check that an item is a class. This strict identity check only holds for classes whose metaclass isexactly
type, so valid subclasses defined with a custom metaclass were wrongly rejected. Useisinstance(v, type)instead.