Skip to content

feat(rpc-metrics): unified RPC latency & error-rate metrics across all services #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hmchangw wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(rpc-metrics): unified RPC latency & error-rate metrics across all services #480

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6485f10
docs(rpc-metrics): design for unified RPC latency & error-rate metrics
claude Jul 8, 2026
5433a86
docs(rpc-metrics): implementation plan for unified RPC metrics
claude Jul 8, 2026
bae5da8
feat(rpcmetrics): shared RPC metrics collectors and status taxonomy
claude Jul 8, 2026
201c3e0
feat(natsrouter): Metrics middleware with route/status plumbing
claude Jul 8, 2026
5b841d0
test(natsrouter): cover Register* status stamping end-to-end
claude Jul 8, 2026
e4402ba
feat(ginutil): HTTP RPC Metrics middleware; errhttp stamps Code
claude Jul 8, 2026
4da118a
test(ginutil): make unmatched-route skip assertion non-tautological
claude Jul 8, 2026
0b611a5
refactor(search-service): use shared natsrouter.Metrics; drop bespoke…
claude Jul 8, 2026
8ffb86e
feat(rpc-metrics): wire natsrouter.Metrics into all request/reply ser…
claude Jul 8, 2026
06b1763
feat(rpc-metrics): wire ginutil.Metrics into all HTTP services
claude Jul 8, 2026
c2ba9eb
fix(rpc-metrics): normalize HTTP status via allowlist; drop testutil …
claude Jul 8, 2026
e5f36d3
refactor(rpc-metrics): extract otelutil.ServeMetrics; reuse errcode h…
claude Jul 8, 2026
5e17791
Merge remote-tracking branch 'origin/main' into claude/rpc-metrics-la…
claude Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions auth-service/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (

"github.com/hmchangw/chat/pkg/ginutil"
pkgoidc "github.com/hmchangw/chat/pkg/oidc"
"github.com/hmchangw/chat/pkg/otelutil"
"github.com/hmchangw/chat/pkg/shutdown"
)

Expand All @@ -24,6 +25,7 @@ type config struct {
AuthAccountPubKey string `env:"AUTH_ACCOUNT_PUB_KEY,required"`
NATSJWTExpiry time.Duration `env:"NATS_JWT_EXPIRY" envDefault:"2h"`
NATSJWTExpiryJitter float64 `env:"NATS_JWT_EXPIRY_JITTER" envDefault:"0.1"`
MetricsAddr string `env:"METRICS_ADDR" envDefault:":9090"`

// OIDC settings — required when DEV_MODE is false.
OIDCIssuerURL string `env:"OIDC_ISSUER_URL"`
Expand Down Expand Up @@ -88,10 +90,17 @@ func run() error {
r := gin.New()
r.Use(gin.Recovery())
r.Use(ginutil.RequestID())
r.Use(ginutil.Metrics("auth-service"))
r.Use(ginutil.AccessLog())
r.Use(ginutil.CORS())
registerRoutes(r, handler)

// /metrics on a separate port so scrapes don't hit the public API listener.
stopMetrics, err := otelutil.ServeMetrics(cfg.MetricsAddr)
if err != nil {
return err
}

addr := fmt.Sprintf(":%s", cfg.Port)
srv := &http.Server{
Addr: addr,
Expand All @@ -109,10 +118,13 @@ func run() error {
shutdownDone := make(chan struct{})
go func() {
defer close(shutdownDone)
shutdown.Wait(ctx, 25*time.Second, func(ctx context.Context) error {
slog.Info("shutting down auth service")
return srv.Shutdown(ctx)
})
shutdown.Wait(ctx, 25*time.Second,
func(ctx context.Context) error {
slog.Info("shutting down auth service")
return srv.Shutdown(ctx)
},
func(ctx context.Context) error { return stopMetrics(ctx) },
)
}()

err = <-srvErr
Expand Down
Loading