Conversation
psylone
approved these changes
Jun 8, 2019
| @@ -1,4 +1,5 @@ | |||
| require 'pathname' | |||
| require_relative 'simpler/middleware/logger' | |||
There was a problem hiding this comment.
Лучше подключить это сразу в config.ru, поскольку middleware там же подключается.
| end | ||
|
|
||
| def set_default_headers | ||
| return @response['Content-Type'] = 'text/plain' if @request.env['simpler.template'].is_a?(Hash) |
There was a problem hiding this comment.
На самом деле, не факт что мы обязательно будет рендерить plain text. Может потребоваться рендеринг json, xml или pdf, например.
|
|
||
| def render(binding) | ||
| template = File.read(template_path) | ||
| template = template_path.is_a?(Hash) ? template_path.first[1] : File.read(template_path) |
There was a problem hiding this comment.
Здесь лучше разделить логику рендеринга ответов разных типов между отдельными классами. Для каждого типа ответа может быть свой собственный класс с методом render. Тогда в обязанности View будет входить выбор нужного класса рендеринга и делегирование ему метода render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.