Skip to content

kueue: Add podSetUpdates to Workload admission checks table - #1237

Open
jayaprajapatii wants to merge 1 commit into
headlamp-k8s:mainfrom
jayaprajapatii:kueue-workload-admission-check-podsetupdates2
Open

kueue: Add podSetUpdates to Workload admission checks table#1237
jayaprajapatii wants to merge 1 commit into
headlamp-k8s:mainfrom
jayaprajapatii:kueue-workload-admission-check-podsetupdates2

Conversation

@jayaprajapatii

Copy link
Copy Markdown

Fixes #1233

PR Summary

Adds podSetUpdates to the Workload Detail page's Admission Checks table.

Problem

status.admissionChecks[] has a podSetUpdates field (labels, annotations, node selector suggested by an AdmissionCheck controller — e.g. a ProvisioningRequest-backed check), but the plugin's AdmissionCheckState type and the Admission Checks table only read the other six fields. This data was invisible in Headlamp; operators had to run kubectl describe workload or read raw YAML to see it.

Fix

  • Added a PodSetUpdate type to workload.ts, matching the v1beta2 API reference.
  • Added renderPodSetUpdates() in workloadFormatters.ts.
  • Added a "Pod Set Updates" column to the Admission Checks table in Detail.tsx.

Testing

  • Added a unit test for renderPodSetUpdates() covering labels, annotations, and node selector.
  • npm run tsc, npm run lint, npm run format --check, and npm run test all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kueue: Workload Admission Checks table omits status.admissionChecks[].podSetUpdates

1 participant