fix(cluster-api): don't let an older copy clear a newer one's checkmark - #1231
Open
magic-peach wants to merge 1 commit into
Open
fix(cluster-api): don't let an older copy clear a newer one's checkmark#1231magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
InlineSolutionPanel can show several quick-fix commands at once, each with its own copy button. handleCopy always cleared copiedCommand back to null after 1800ms, so copying command A then copying command B within that window meant A's timeout fired later and blanked B's checkmark early, even though B's own 1800ms hadn't elapsed yet. Only clear the state if it still matches the command that timeout was set for. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
magic-peach
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 21, 2026 06:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InlineSolutionPanel shows several quick-fix commands at once, each with its own copy button.
handleCopyalways resetcopiedCommandto null 1800ms after any copy, so copying command A and then command B within that window meant A's timeout fired later and cleared B's checkmark before B's own 1800ms was actually up.Only clear the state if it's still the command that particular timeout belongs to.
Added a test that copies two commands in quick succession and checks the second one's checkmark survives the first one's timeout.